v3 - translate full path #781
Merged
+572
−368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
c1d689e to
c46a79f
Compare
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
c46a79f to
daa1fc0
Compare
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
daa1fc0 to
c9e00be
Compare
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
c9e00be to
f126352
Compare
mathiazom
changed the base branch from
v3
to
refactor/v3-query-response-type-narrowing
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
f126352 to
7c95f84
Compare
Base automatically changed from
refactor/v3-query-response-type-narrowing
to
v3
October 16, 2024 10:52
mathiazom
force-pushed
the
feat/v3-translate-full-path
branch
from
7c95f84 to
915b384
Compare
…guage, before checking other languages given pages `/en/gift`,`/no/gave`,`/en/poison`,`/no/gift` and user language `en`, we should redirect `/gift` to `/en/poison` and not `/en/gift`
anemne
reviewed
Oct 16, 2024
anemne
approved these changes
Oct 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #733
The
useLanguageclient hook has been removed in favor of providing the path translation together with the page data. This also means that the translations are fetched on the server instead of on the client.In order to allow this, the header component has been moved from the root
layout.tsxto each page. This is because theLanguageSwitcherinHeaderneeds access to the page data, which is not available inlayout.tsx. This approach is similar to the Sanity example projectdemo-course-platform.